JS: add the resolve library as a sink to js/path-injection#6015
Merged
Conversation
erik-krogh
added
the
Awaiting evaluation
erik-krogh
removed
the
Awaiting evaluation
| ResolveModuleSink() { | ||
| this = API::moduleImport("resolve").getACall().getArgument(0) | ||
| or | ||
| this = API::moduleImport("resolve").getMember("sync").getACall().getArgument(0) |
Contributor
There was a problem hiding this comment.
Maybe also add a test for this disjunct?
erik-krogh
changed the title
resolve library as a sink to js/path-injection
asgerf
approved these changes
Jun 8, 2021
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
👍. Even if the result doesn't flow to require, it can be used to probe the existence of files on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolve library is used to e.g. import a module as if you are in another directory.
E.g.
An alternative would be to treat it as a taint-step, but I feel it's more appropriate to treat it as a sink.
Evaluation looks fine.